Use body banner images as fallback background#408
Merged
Conversation
querySelector("img.preferred-image, img") returns the first match in
document order, not selector-list order, so a plain img preceding an
img.preferred-image would win. Split into two queries so
img.preferred-image is always preferred.
fernanDOTdo
approved these changes
Jul 22, 2026
fernanDOTdo
marked this pull request as ready for review
July 22, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UseBodyBannerImageAsBackground(default FALSE, client themes must opt-in to this behavior change)body-bannerforimgand use it as the page background IF thepage-backgroundImagesection exists and doesn't already have an imagePageBackgroundto run beforeMediaAttributionso that cloned image can be attributed